refactor(wasm)!: Make WASM module interface more like Python module #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
requested changes
Nov 13, 2025
Collaborator
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Could you add a ### Changed entry to the CHANGELOG? We probably need a PR template to remind folks of that, as well.
alukach
force-pushed
the
refactor/wasm/use-expr
branch
from
82e8534 to
557be88
Compare
alukach
changed the title
alukach
commented
Nov 13, 2025
Member
Author
|
@gadomski not sure why that last build failed but I think we're good to go now |
gadomski
approved these changes
Nov 13, 2025
Member
|
At some point I'd love to look into your wasm bindings in more detail! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to normalize the interface between Python and WASM runtimes.
cql2::ExprCurrently, we expose the
cql2::Exprstruct asCQL2in WASM butExprin Python. This PR alters the WASM library to exposecql2::ExprasExpr.Expr.matches(item)andExpr.reduce(item)Currently, the WASM library expects strings to be passed into
Expr.matches(item)andExpr.reduce(item)while the Python module expectsdictinstances. This PR alters the WASM library to expect JS Values (aka POJOs) in theExpr.matches(item)andExpr.reduce(item)methods.Expr.to_json()Currently, the WASM library returns a string from
Expr.to_json()while the Python module returns adictinstance. This PR alters the WASM library to return JS Values fromExpr.to_json().Note
Expr.to_pretty_json()still returns a string, which is a bit awkward but there's no such thing as a pretty JS value.